Conversation
|
The only thing missing here is the parser preprocessing for |
|
I will try to review asap, but I first have to catch up on the latest status of the treetransform stuff, as I never managed to review that part of the vectorize fusiontrees PR. |
Codecov Report❌ Patch coverage is
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Anything more need doing here or is this ready to go after #389? |
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
kshyatt
force-pushed
the
ksh/cubt
branch
2 times, most recently
from
f787d47 to
e7361df
Compare
lkdvos
left a comment
lkdvos
left a comment
There was a problem hiding this comment.
I guess the main thing missing is still the @planar changes... I will try to find some time, but I seem to be having a million things 🙃
|
I'll work on the preprocessor, don't worry about it! But my solution might be a bit ugly... |
|
OK, a lot of comments resolved (hopefully!) |
|
CUDA test fail here seems unrelated, I'm running locally to see if I can repro |
|
Aaaaaand I can't repro locally! |
|
I'm still confused by this factorization test failure, which I cannot locally reproduce and only occurs for Update: this was also failing here, so maybe it's unrelated |
|
In the meantime, I removed the braiding check commit and squashed a bunch of intermediate stuff that was messing around with CUDA. Let's see how GPU CI does now... |
|
Ok, this looks good to me. I haven't read through the test file in detail; I hope to get to a more massive test review and update at some later stage. |
|
Thanks! I agree we should take another swing at all these tests |
Co-authored-by: Jutho <Jutho@users.noreply.github.com>
|
I really cannot figure out this factorization test, which I can repro failing locally on |
|
Now it passes!!! I seriously wonder if the |
|
In guessing the interaction with the RNG changes in the --fast specification . In any case, id like to have a look at this for a final round of review but might have to be later today since I still have some other things to get to |
|
Sure, makes sense to me. I'm just completely wowed by this bug if it's real, it's so silly |
3 participants
This is probably the nicest way to unblock the various MPSKit changes. I found the
similarmatrixtypeapproach the least gross looking way to achieve this, but open to other ideas.